Skip to content

Conversation

@yonasberhe23
Copy link
Contributor

Summary

Fixes #rancher/qa-tasks#2043

Cloud credential tests were failing due to test execution order and possibly intercept conflicts. This PR:

  • Moves credential creation tests to run after tests that expect no existing credentials
  • Removes testIsolation: false to prevent intercept conflicts between tests
  • Ensures test execution order doesn't interfere with credential form state expectations

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

@yonasberhe23 yonasberhe23 added this to the v2.13.0 milestone Oct 23, 2025
@yonasberhe23 yonasberhe23 self-assigned this Oct 23, 2025
@yonasberhe23 yonasberhe23 marked this pull request as ready for review October 23, 2025 19:27
@yonasberhe23 yonasberhe23 changed the title Automation: fix cloud creds tests part 2 Automation: Fix cloud creds tests part 2 Oct 23, 2025
@izaac
Copy link
Contributor

izaac commented Oct 23, 2025

This is looking great. Let us know when you feel the Jenkins pipeline is stable and ready.

@yonasberhe23 yonasberhe23 force-pushed the fix_cloud_cred_tests_p2 branch from edb8493 to 5b44853 Compare October 24, 2025 15:50
@yonasberhe23
Copy link
Contributor Author

Tests are passing in Jenkins with the latest updates:

image

@yonasberhe23 yonasberhe23 force-pushed the fix_cloud_cred_tests_p2 branch from 5b44853 to cab9d68 Compare October 27, 2025 16:28
Copy link
Contributor

@izaac izaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: the new execution order looks good, and is reported stable in the pipelines.

@yonasberhe23 yonasberhe23 force-pushed the fix_cloud_cred_tests_p2 branch from cab9d68 to a948d85 Compare October 28, 2025 16:26
@yonasberhe23 yonasberhe23 merged commit 15dc082 into rancher:master Oct 28, 2025
33 checks passed
@yonasberhe23 yonasberhe23 deleted the fix_cloud_cred_tests_p2 branch October 28, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants