Skip to content

Conversation

@yonasberhe23
Copy link
Contributor

@yonasberhe23 yonasberhe23 commented Oct 23, 2025

Summary

Fixes #rancher/qa-tasks#2078

Follow-up fix: I missed updating the githubapp.spec.ts file in the previous URL assertion changes.

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

@yonasberhe23 yonasberhe23 merged commit 5b327d3 into rancher:master Oct 24, 2025
141 of 151 checks passed
@yonasberhe23 yonasberhe23 deleted the fix_url_assertion_p2 branch October 24, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants