GitHub App auth provider: Pass validation when configuring users and groups #15684
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This allows the GitHub/GitHub App auth providers to pass validation when configuring users and groups.
Fixes #15648
Occurred changes and/or fixed issues
Technical notes summary
The github app auth provider was preventing admins from configuring users and groups because validation will fail without a client secret. Other auth providers, like
shell/edit/auth/oidc.vue, get around this by short-circuiting to true when not editing the config.Areas or cases that should be tested
Areas which could experience regressions
NA
Screenshot/Video
NA
Checklist
Admin,Standard UserandUser Base