Skip to content

Conversation

@rak-phillip
Copy link
Member

@rak-phillip rak-phillip commented Oct 21, 2025

Summary

This allows the GitHub/GitHub App auth providers to pass validation when configuring users and groups.

Fixes #15648

Occurred changes and/or fixed issues

  • Pass validation when configuring users and groups

Technical notes summary

The github app auth provider was preventing admins from configuring users and groups because validation will fail without a client secret. Other auth providers, like shell/edit/auth/oidc.vue, get around this by short-circuiting to true when not editing the config.

Areas or cases that should be tested

  • GitHub auth provider
  • GitHub App auth provider

Areas which could experience regressions

NA

Screenshot/Video

NA

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

Copy link
Member

@eva-vashkevich eva-vashkevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rak-phillip rak-phillip force-pushed the bugfix/15648-gh-app-validation branch from f90d76a to d0801db Compare October 22, 2025 21:51
The github app auth provider was preventing admins from configuring users and groups because validation will fail without a client secret. Other auth providers, like `shell/edit/auth/oidc.vue`, get around this by short-circuiting to true when not editing the config.

Signed-off-by: Phillip Rak <[email protected]>
@rak-phillip rak-phillip force-pushed the bugfix/15648-gh-app-validation branch from d0801db to 88f3867 Compare October 24, 2025 22:36
@rak-phillip rak-phillip merged commit 1111656 into rancher:master Oct 27, 2025
140 of 145 checks passed
@rak-phillip rak-phillip deleted the bugfix/15648-gh-app-validation branch October 27, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Github App auth provider configure authorized users and groups not saving initially

2 participants