Replace a modal resize hack with usage of the action-menu store. #15683
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Note: this is for 2.14.
Fixes #10559
Technical notes summary
We were hackily modifying the width of a modal dialog. This uses our existing action-menu store responsible for managing the state of the modals to update the width of the modal which is already reactive.
Areas or cases that should be tested
WorkloadRollbackDialog when switching toggling between show/hide diff.
Areas which could experience regressions
WorkloadRollbackDialog when switching toggling between show/hide diff.
Screenshot/Video
sizedialog.mp4
Checklist
Admin,Standard UserandUser Base