-
Notifications
You must be signed in to change notification settings - Fork 302
Add architecture filter to EKS node group #15672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mantis-toboggan-md
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good overall and represents a nice enhancement to EKS provisioning. I had only one minor complaint: it would be nice if the instance type selection wasn't cleared when switching back to 'all' in the architecture filter.
Before my changes enabling and disabling Request Spot... checkbox clears the previously selected instance type, I thought I should follow the same pattern, but I can work on it UPDATE: done |
mantis-toboggan-md
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Fixes #11629
Occurred changes and/or fixed issues
I have updated the issue's description with UI Requirements, please check them.
ARMorx86_64, but now you canTechnical notes summary
filterByArchitecture(options), was implemented. It processes a flat list of instance type options (including group headers), filters them based on whether theirsupportedArchitecturesarray contains the selected architecture, and returns a new filtered flat list.Areas or cases that should be tested
Areas which could experience regressions
Both Edit and Create modes should be tested:
Screenshot/Video
eks-pr.mov
Checklist
Admin,Standard UserandUser Base