Skip to content

Conversation

@richard-cox
Copy link
Member

@richard-cox richard-cox commented Oct 17, 2025

Occurred changes and/or fixed issues

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

Copy link
Member

@aalves08 aalves08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @richard-cox . One question: did anything have to change in terms of permissions on ui-plugin-examples side or the needed fix was just on dashboard's reusable workflow with pull-requests: write and env: GH_TOKEN: ${{ github.token }}.

just wanting to confirm because I am hitting a similar problem with ui-plugin-charts with creating a PR although the workflow is self-contained on the ui-plugin-charts repo rancher/ui-plugin-charts#137

PR is still not 100% correct, but the gist of it is there

@richard-cox
Copy link
Member Author

richard-cox commented Oct 20, 2025

@aalves08 yep! you'll need to mirror the changes in creators/extension/app/files/.github/workflows/build-extension-charts.yml to the version in ui-plugin-charts. in ui-plugin-examples that change had already been made

Edit: just pull-requests: write is needed in the calling repo. that calls out repo's .github/workflows/build-extension-charts.yml which has the gh token changes.

@richard-cox richard-cox merged commit 40b8996 into master Oct 20, 2025
65 of 67 checks passed
@richard-cox richard-cox deleted the plugin-examples-build-fix branch October 20, 2025 11:24
a110605 pushed a commit to a110605/harvester-dashboard that referenced this pull request Oct 21, 2025
…ancher#15655)

* Ensure build-extension-charts runs that create PRs have GH_TOKEN set

* add optional override to github.token

* Revert "add optional override to github.token"

This reverts commit c666839.

* move env to correct step....

* add permisions to step

* add to other file, fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants