-
Notifications
You must be signed in to change notification settings - Fork 302
Ensure extension repo build and release feature works when using PRs #15655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit c666839.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @richard-cox . One question: did anything have to change in terms of permissions on ui-plugin-examples side or the needed fix was just on dashboard's reusable workflow with pull-requests: write and env: GH_TOKEN: ${{ github.token }}.
just wanting to confirm because I am hitting a similar problem with ui-plugin-charts with creating a PR although the workflow is self-contained on the ui-plugin-charts repo rancher/ui-plugin-charts#137
PR is still not 100% correct, but the gist of it is there
|
@aalves08 yep! you'll need to mirror the changes in creators/extension/app/files/.github/workflows/build-extension-charts.yml to the version in ui-plugin-charts. in ui-plugin-examples that change had already been made Edit: just |
…ancher#15655) * Ensure build-extension-charts runs that create PRs have GH_TOKEN set * add optional override to github.token * Revert "add optional override to github.token" This reverts commit c666839. * move env to correct step.... * add permisions to step * add to other file, fix typo
Occurred changes and/or fixed issues
.github/workflows/build-extension-charts.ymlworkflow to build extension helm chartscreate_prwhich creates a PR with the changes instead of pushing directly to a branchRun build scriptcurrently fails due to a missing GH_TOKEN env var - https://github.com/rancher/ui-plugin-examples/actions/runs/18319242795/job/52167913911Checklist
Admin,Standard UserandUser Base