Skip to content

Conversation

@aalves08
Copy link
Member

@aalves08 aalves08 commented Oct 15, 2025

Summary

Fixes #15635

Occurred changes and/or fixed issues

  • add new checklist item to test PRs with different user roles

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility

@aalves08 aalves08 added this to the v2.13.0 milestone Oct 15, 2025
@aalves08 aalves08 self-assigned this Oct 15, 2025
cnotv
cnotv previously approved these changes Oct 15, 2025
Copy link
Member

@cnotv cnotv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac
Copy link
Member

nwmac commented Oct 15, 2025

@aalves08 Is there an issue for this? Can we create one and attach if not.

@aalves08
Copy link
Member Author

@aalves08 Is there an issue for this? Can we create one and attach if not.

created the issue and updated the body @nwmac 🙏

@aalves08 aalves08 merged commit 783f7f3 into rancher:master Oct 16, 2025
112 of 117 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve PR checklist to take into account different user roles

4 participants