Skip to content

Conversation

@a110605
Copy link
Member

@a110605 a110605 commented Oct 15, 2025

Summary

Fixes # check-plugins-build / validate (pull_request) CI failed
https://github.com/rancher/dashboard/actions/runs/18522411120/job/52785189448?pr=15625

Occurred changes and/or fixed issues

The PR changes rancher-extension-stackstate minimial node requirement to 22 which causes build-plugin.yaml yarn install failed.

image

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility

@a110605 a110605 added this to the v2.13.0 milestone Oct 15, 2025
@a110605 a110605 changed the title fix: yarn install for rancher-extension-stackstate fix: yarn install failed for rancher-extension-stackstate Oct 15, 2025
Copy link
Member

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use the node-version-file approach to ensure all places that reference node versions (19) use the same one.

Until we resolve this stackstack will be limited to the same node version of shell + the dashboard as a whole

@a110605
Copy link
Member Author

a110605 commented Oct 15, 2025

We use the node-version-file approach to ensure all places that reference node versions (19) use the same one.

Until we resolve this stackstack will be limited to the same node version of shell + the dashboard as a whole

Will we ask rancher-extension-stackstate to downgrade their required node to 20 ?

@richard-cox
Copy link
Member

Just worked this through with Alex and we'll temp disable that extension (#15629) and discuss with stackstate on node version

@a110605 a110605 closed this Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants