Skip to content

Conversation

@a110605
Copy link
Member

@a110605 a110605 commented Oct 15, 2025

Summary

Fixes #15169

Occurred changes and/or fixed issues

In harvester, the warning button text doens't look obviously in dark mode. Light mode looks fine.
image

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Before

Screenshot 2025-10-15 at 4 09 00 PM

After
Screenshot 2025-10-15 at 4 09 25 PM

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility

@a110605 a110605 requested review from houhoucoop, kwwii and nwmac October 15, 2025 08:17
@a110605 a110605 self-assigned this Oct 15, 2025
@rancher-ui-project-bot rancher-ui-project-bot bot added this to the v2.13.0 milestone Oct 15, 2025
@a110605 a110605 changed the title fix: warning text color in dark mode fix: warning text color is not obvious in dark mode Oct 15, 2025
@nwmac
Copy link
Member

nwmac commented Oct 15, 2025

@a110605 This will need a rebase to pick up a test fix in the master branch

@a110605 a110605 force-pushed the fix_warning_text_color branch from e9c0574 to db841ab Compare October 15, 2025 16:10
@a110605 a110605 merged commit cbe91a9 into rancher:master Oct 16, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update colors for modern theme

2 participants