Skip to content

Conversation

@yonasberhe23
Copy link
Contributor

@yonasberhe23 yonasberhe23 commented Oct 14, 2025

Summary

Fixes #rancher/qa-tasks#2046

Did some refactoring, but the main purpose of this PR is to fix failing tests related to cluster detail page navigation and tab functionality by:

  • Adding filtering before navigation to ensure the page settles before interacting with it.
  • Added waitForPage() calls to ensure we're on the correct page before proceeding with test actions.

Screenshot/Video

Screenshot 2025-10-15 at 7 56 22 AM

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility

@yonasberhe23 yonasberhe23 self-assigned this Oct 14, 2025
@yonasberhe23 yonasberhe23 added this to the v2.13.0 milestone Oct 14, 2025
@yonasberhe23 yonasberhe23 changed the title fix cluster details page tests Automation: fix cluster details page tests Oct 14, 2025
@yonasberhe23 yonasberhe23 marked this pull request as ready for review October 15, 2025 15:06
@yonasberhe23 yonasberhe23 force-pushed the fix_cluster_detail_tabs_tests branch from 6472439 to a8d2aee Compare October 15, 2025 15:08
@yonasberhe23 yonasberhe23 requested a review from izaac October 15, 2025 15:09
@yonasberhe23 yonasberhe23 force-pushed the fix_cluster_detail_tabs_tests branch from a8d2aee to a8e8836 Compare October 15, 2025 18:19
Copy link
Contributor

@izaac izaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid PR.

LGTM. Improves test stability and POM pattern.

@yonasberhe23 yonasberhe23 merged commit 0764cdc into rancher:master Oct 16, 2025
87 of 89 checks passed
@yonasberhe23 yonasberhe23 deleted the fix_cluster_detail_tabs_tests branch October 16, 2025 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants