Skip to content

Automation: fix repositories test #15619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yonasberhe23 merged 1 commit into from
Oct 15, 2025
Merged

Automation: fix repositories test #15619

yonasberhe23 merged 1 commit into from
Oct 15, 2025

Conversation

@yonasberhe23
Copy link
Contributor

@yonasberhe23 yonasberhe23 commented Oct 13, 2025 •
edited
Loading

Summary

Fixes #rancher/qa-tasks#2053

Fixes flaky repository tests:

  • Replaced closeActionMenu() escape key method with proper rowActionMenuClose() that validates aria-expanded state
  • Added cy.waitForRepositoryDownload() and cy.waitForResourceState() to replace arbitrary waits
  • Simplified deletion logic using cy.deleteRancherResource() and removed redundant methods

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility

@yonasberhe23 yonasberhe23 added this to the v2.13.0 milestone Oct 13, 2025
@yonasberhe23 yonasberhe23 self-assigned this Oct 13, 2025
@yonasberhe23 yonasberhe23 marked this pull request as ready for review October 13, 2025 21:45
@yonasberhe23 yonasberhe23 requested review from IsaSih and izaac October 13, 2025 21:45
@yonasberhe23 yonasberhe23 changed the title fix repositories test Automation: fix repositories test Oct 13, 2025
izaac
izaac reviewed Oct 14, 2025
View reviewed changes
@yonasberhe23 yonasberhe23 requested a review from izaac October 14, 2025 22:55
izaac
izaac requested changes Oct 15, 2025
View reviewed changes
Copy link
Contributor

@izaac izaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit. Looking good.

@yonasberhe23 yonasberhe23 force-pushed the fix_repositories_test branch from 0a9411f to f38280e Compare October 15, 2025 04:24
@yonasberhe23 yonasberhe23 requested a review from izaac October 15, 2025 04:26
@yonasberhe23 yonasberhe23 force-pushed the fix_repositories_test branch from f38280e to 8587c2c Compare October 15, 2025 13:25
izaac
izaac approved these changes Oct 15, 2025
View reviewed changes
Copy link
Contributor

@izaac izaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@yonasberhe23 yonasberhe23 merged commit 1024889 into rancher:master Oct 15, 2025
60 of 61 checks passed
@yonasberhe23 yonasberhe23 deleted the fix_repositories_test branch October 15, 2025 14:51
@yonasberhe23 yonasberhe23 mentioned this pull request Nov 10, 2025
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@izaac izaac izaac approved these changes

@IsaSih IsaSih Awaiting requested review from IsaSih

Assignees

@yonasberhe23 yonasberhe23

Labels

area/e2e QA/None

Projects

None yet

Milestone

v2.13.0

Development

Successfully merging this pull request may close these issues.

2 participants

@yonasberhe23 @izaac