Skip to content

Conversation

@codyrancher
Copy link
Member

@codyrancher codyrancher commented Oct 13, 2025

Summary

Fixes #14728

Occurred changes and/or fixed issues

Changed one of the conditions so that we still show the editor even when an error is present.

Areas or cases that should be tested

Verify edit config and edit yaml both function as expected when an error is present.

Areas which could experience regressions

Same as above,

Screenshot/Video

edit-error-1.mp4
image

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility

@codyrancher codyrancher added this to the v2.13.0 milestone Oct 13, 2025
@codyrancher codyrancher requested a review from momesgin October 13, 2025 19:25
@codyrancher codyrancher marked this pull request as ready for review October 13, 2025 20:06
@codyrancher codyrancher merged commit 872fa55 into rancher:master Oct 15, 2025
114 of 120 checks passed
@codyrancher codyrancher deleted the edit-yaml-error branch October 15, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Errors not visible in Edit YAML view

2 participants