Skip to content

Conversation

@rak-phillip
Copy link
Member

@rak-phillip rak-phillip commented Oct 10, 2025

Summary

This updates the logout endpoint to v1/logout.

Fixes # 15326
Contributes to #15326

Occurred changes and/or fixed issues

  • Migrate logout endpoint from v3/tokens to v1/logout
  • Update the logout action to match the requirements for the new endpoint

Technical notes summary

This appears to behave mostly the same as before - the biggest change is that there is no logoutAction for the base case.

Areas or cases that should be tested

Local & Auth Providers logout actions, including SLO.

Areas which could experience regressions

Local & Auth Providers logout actions, including SLO.

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility

@rak-phillip
Copy link
Member Author

This depends on rancher/rancher#51284 to merge

Copy link
Member

@aalves08 aalves08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rak-phillip something is wrong here:

Amazon Cognito OIDC:
https://github.com/user-attachments/assets/56cc7a2c-0308-40e2-b9d6-80cce75f2fed

Okta SAML:
https://github.com/user-attachments/assets/c477d81c-d0c5-47b5-8fec-ff5316f4938d

While trying both "full" logout's the URL the network request looks good logout&all but on both I was expecting to have to enter the credentials when logging back in, which didn't happen. I did a quick look-around of the UI's code and couldn't find anything suspicious/missing in relation to this PR. I am really thinking this might be a backend problem 🤔

I would say the best person to also cross-check this on Collie's side is Kevin McDermott since we worked together on the OIDC single-logout and he did a bit of refactoring to the logic on the backend side since we now support the feature in both SAML and OIDC providers 🙏

@aalves08
Copy link
Member

@pmatseykanets @rak-phillip today I gave this a test without @rak-phillip change and the single-logout feature is currently broken 🙏

@richard-cox
Copy link
Member

Please all bear in mind that this is currently a 2.14 issue and pr

@aalves08
Copy link
Member

aalves08 commented Oct 21, 2025

@rak-phillip @pmatseykanets I can confirm that with @pmatseykanets changes rancher/rancher#52417, v2.13-af003d7ebf4d6e577c402ab8bf406c75ebd6992f-head, SLO is working on this PR for both SAML and OIDC providers.

Normal user logout + login with user+pass also working with this change.
The "normal" logout + login on OIDC is fine.
The "normal" logout + login on SAML is fine as well.

I tested v2.13-af003d7ebf4d6e577c402ab8bf406c75ebd6992f-head without @rak-phillip changes and all seems fine in all scenarios

@rak-phillip
Copy link
Member Author

aalves08
aalves08 previously approved these changes Oct 21, 2025
Copy link
Member

@aalves08 aalves08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@aalves08 aalves08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rak-phillip rak-phillip merged commit 5b44ee9 into rancher:master Nov 19, 2025
60 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants