Skip to content

Conversation

@yonasberhe23
Copy link
Contributor

@yonasberhe23 yonasberhe23 commented Oct 9, 2025

Summary

Fixes #

This PR addresses ConfigMap test failures:

  • Added assertions before clicking on action menu items to prevent race conditions.
  • Added row count verification to ensure data is properly loaded before proceeding.
  • Replaced arbitrary wait with waitForPage method.
  • Also refactored the page object files.

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility

@yonasberhe23 yonasberhe23 self-assigned this Oct 9, 2025
@yonasberhe23 yonasberhe23 force-pushed the configmap_test_fix branch 6 times, most recently from 21c3f5c to 2878662 Compare October 10, 2025 04:53
@yonasberhe23 yonasberhe23 added this to the v2.13.0 milestone Oct 10, 2025
@yonasberhe23 yonasberhe23 marked this pull request as ready for review October 10, 2025 05:20
@yonasberhe23 yonasberhe23 merged commit 4b65445 into rancher:master Oct 10, 2025
59 of 61 checks passed
@yonasberhe23 yonasberhe23 deleted the configmap_test_fix branch October 10, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants