-
Notifications
You must be signed in to change notification settings - Fork 302
Update Shell API's method signatures and enable typedoc integration #15605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
aalves08
merged 29 commits into
rancher:master
from
aalves08:15597-update-shell-api-method-signatures
Dec 16, 2025
Merged
Update Shell API's method signatures and enable typedoc integration #15605
aalves08
merged 29 commits into
rancher:master
from
aalves08:15597-update-shell-api-method-signatures
Dec 16, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1e1160c to
3d2dd0a
Compare
nwmac
requested changes
Nov 28, 2025
3d2dd0a to
7c6fe46
Compare
…nts on shell interface
…ck notification types for its own file and remove notificationLevel duplication + fix imports/exports on shell api interfaces + remove API from interfaces names
57e7d92 to
6afcb18
Compare
This was referenced Dec 15, 2025
nwmac
approved these changes
Dec 16, 2025
Member
nwmac
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is okay to get in - there are a few follow-ups to look at.
Need to work out between interfaces and types for some things. Some interfaces show up like EncryptedNotification that we probably don't want to see.
But, I'd suggest we get this in and iterate forward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #15597
Fixes #15850
Important notice: needs a rebase from #15532 once that's merged
Occurred changes and/or fixed issues
Notification Centerwith the Shell APIgrowlsfrom Shell API (deprecated)SystemAPI to Shell APITechnical notes summary
Areas or cases that should be tested
Areas which could experience regressions
Screenshot/Video
Checklist