Skip to content

Conversation

@yonasberhe23
Copy link
Contributor

Summary

Fixes #rancher/qa-tasks#1941

Before: Tests were failing because they expected messages at a specific array index (messages[2]) which was often undefined
After: Tests now use messages.find() to search through all received messages for the expected content

Screenshot/Video

Screenshot 2025-10-08 at 9 11 21 PM

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility

@yonasberhe23 yonasberhe23 added this to the v2.13.0 milestone Oct 9, 2025
@yonasberhe23 yonasberhe23 requested review from IsaSih and izaac October 9, 2025 04:18
@yonasberhe23 yonasberhe23 self-assigned this Oct 9, 2025
Copy link
Contributor

@izaac izaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straightforward and good. Good catch.

@yonasberhe23 yonasberhe23 merged commit 0354257 into rancher:master Oct 10, 2025
60 of 61 checks passed
@yonasberhe23 yonasberhe23 deleted the fix_websocket_tests branch October 10, 2025 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants