Skip to content

Conversation

@rak-phillip
Copy link
Member

@rak-phillip rak-phillip commented Oct 7, 2025

Summary

This attempts to strip closing keywords from the body of a backport PR.

Occurred changes and/or fixed issues

  • Strip closing keywords from the body

Technical notes summary

Previous attempts to prevent altering backport PR milestones haven't worked. I think that a straightforward approach will be to attempt removal of closing keywords from the PR body, this should stop the .github/workflows/scripts/pr-gh-project.js script from altering the milestone based on the linked issues.

Areas or cases that should be tested

Backporting PRs should no longer set the milestone to that of the original issue.

Areas which could experience regressions

This change could inadvertently clobber the body of the backport PR in undefined ways.

Screenshot/Video

NA

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility

@rak-phillip rak-phillip force-pushed the task/backport-closing-keywords branch from 4ccb9b4 to 272bac2 Compare November 17, 2025 20:10
@rak-phillip rak-phillip added this to the v2.14.0 milestone Nov 17, 2025
@rak-phillip rak-phillip marked this pull request as ready for review November 17, 2025 20:18
codyrancher
codyrancher previously approved these changes Nov 17, 2025
Copy link
Member

@codyrancher codyrancher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with the change. I did have one thought though. May instead of replacing with white space we do something like "Original text redacted by port-pr.yaml" to avoid confusion and make it easier to track in the future.

@rak-phillip
Copy link
Member Author

I'm fine with the change. I did have one thought though. May instead of replacing with white space we do something like "Original text redacted by port-pr.yaml" to avoid confusion and make it easier to track in the future.

I like this approach. Ready for another review.

@rak-phillip rak-phillip merged commit ef812ab into rancher:master Nov 19, 2025
85 of 89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants