-
Notifications
You must be signed in to change notification settings - Fork 302
Update colors for SUSE Prime Theme #15557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2f7d9e0 to
ac28f19
Compare
richard-cox
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
styles/code look good, light mode looks nice, question about dark mode (in slack)
Bonus, not related to PR..... We should (in another PR) update the spinner colour in the splash page to align with the modern theme (https://github.com/rancher/dashboard/blob/master/shell/public/index.html#L32). Unfortunately we can't determine brand (suse / modern) at that point in loading, only theme (light / dark)
f79d97b to
edddf42
Compare
richard-cox
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets get everything in a see how that dark mode green works with all the other changes
Signed-off-by: Phillip Rak <[email protected]>
Signed-off-by: Phillip Rak <[email protected]>
Signed-off-by: Phillip Rak <[email protected]>
Signed-off-by: Phillip Rak <[email protected]>
Signed-off-by: Phillip Rak <[email protected]>
Signed-off-by: Phillip Rak <[email protected]>
Signed-off-by: Phillip Rak <[email protected]>
edddf42 to
1165f16
Compare
|
@rak-phillip There was 1 genuine e2e test failure - we were checking the width of the SUSE logo, and this had changed. I have pushed a commit to update the e2e test. |
|
@rak-phillip Hope you don't mind - got this to pass gates now, will merge. |
* Update Prime theme Signed-off-by: Phillip Rak <[email protected]> * Update prime theme colors Signed-off-by: Phillip Rak <[email protected]> * Preserve Prime colors in top level menu Signed-off-by: Phillip Rak <[email protected]> * Update Prime theme colors Signed-off-by: Phillip Rak <[email protected]> * Update Prime logos Signed-off-by: Phillip Rak <[email protected]> * Primary keyboard focus Signed-off-by: Phillip Rak <[email protected]> * Update Prime dark mode secondary hover Signed-off-by: Phillip Rak <[email protected]> * Fix log width in e2e test --------- Signed-off-by: Phillip Rak <[email protected]> Co-authored-by: Neil MacDougall <[email protected]>
Summary
This updates the Prime theme to use the new styles defined by the UX team.
Fixes #15168
Occurred changes and/or fixed issues
Technical notes summary
This modifies colors and variables present in
shell/assets/styles/themes/_suse.scss. The aim of this PR is to focus on colors for the Prime theme.Areas or cases that should be tested
Set the brand to "suse".
Areas which could experience regressions
Accessibility concerns with regards to color contrast. Mismatched colors in components.
Screenshot/Video
NA
Checklist