Skip to content

Conversation

@rak-phillip
Copy link
Member

@rak-phillip rak-phillip commented Oct 1, 2025

Summary

This updates the Prime theme to use the new styles defined by the UX team.

Fixes #15168

Occurred changes and/or fixed issues

  • Updates colors in the modern theme to match the new designs
  • Updates Prime logos

Technical notes summary

This modifies colors and variables present in shell/assets/styles/themes/_suse.scss. The aim of this PR is to focus on colors for the Prime theme.

Areas or cases that should be tested

Set the brand to "suse".

Areas which could experience regressions

Accessibility concerns with regards to color contrast. Mismatched colors in components.

Screenshot/Video

NA

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility

@rancher-ui-project-bot rancher-ui-project-bot bot added this to the v2.13.0 milestone Oct 1, 2025
@rak-phillip rak-phillip force-pushed the task/15168-prime-theme branch 7 times, most recently from 2f7d9e0 to ac28f19 Compare October 6, 2025 18:37
@rak-phillip rak-phillip marked this pull request as ready for review October 6, 2025 18:37
Copy link
Member

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

styles/code look good, light mode looks nice, question about dark mode (in slack)

Bonus, not related to PR..... We should (in another PR) update the spinner colour in the splash page to align with the modern theme (https://github.com/rancher/dashboard/blob/master/shell/public/index.html#L32). Unfortunately we can't determine brand (suse / modern) at that point in loading, only theme (light / dark)

richard-cox
richard-cox previously approved these changes Oct 24, 2025
Copy link
Member

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets get everything in a see how that dark mode green works with all the other changes

@rak-phillip rak-phillip force-pushed the task/15168-prime-theme branch from edddf42 to 1165f16 Compare October 24, 2025 22:36
@nwmac
Copy link
Member

nwmac commented Oct 27, 2025

@rak-phillip There was 1 genuine e2e test failure - we were checking the width of the SUSE logo, and this had changed. I have pushed a commit to update the e2e test.

@nwmac
Copy link
Member

nwmac commented Oct 27, 2025

@rak-phillip Hope you don't mind - got this to pass gates now, will merge.

@nwmac nwmac merged commit 8cf69ab into rancher:master Oct 27, 2025
87 of 92 checks passed
@rak-phillip rak-phillip deleted the task/15168-prime-theme branch October 27, 2025 15:32
nwmac added a commit to nwmac/dashboard that referenced this pull request Oct 29, 2025
* Update Prime theme

Signed-off-by: Phillip Rak <[email protected]>

* Update prime theme colors

Signed-off-by: Phillip Rak <[email protected]>

* Preserve Prime colors in top level menu

Signed-off-by: Phillip Rak <[email protected]>

* Update Prime theme colors

Signed-off-by: Phillip Rak <[email protected]>

* Update Prime logos

Signed-off-by: Phillip Rak <[email protected]>

* Primary keyboard focus

Signed-off-by: Phillip Rak <[email protected]>

* Update Prime dark mode secondary hover

Signed-off-by: Phillip Rak <[email protected]>

* Fix log width in e2e test

---------

Signed-off-by: Phillip Rak <[email protected]>
Co-authored-by: Neil MacDougall <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update colors for SUSE Prime theme

3 participants