Skip to content

Conversation

@torchiaf
Copy link
Member

@torchiaf torchiaf commented Sep 8, 2025

Summary

Fixes #15344

Technical notes summary

  • It adds Secrets and ConfigMaps selector in the HelmOp wizard

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

image

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility

@torchiaf torchiaf added this to the v2.13.0 milestone Sep 8, 2025
@torchiaf torchiaf changed the title Fleet HelmOps select Secrets and ConfigMaps Fleet HelmOps asign Secrets and ConfigMaps Sep 8, 2025
@torchiaf torchiaf changed the title Fleet HelmOps asign Secrets and ConfigMaps Fleet HelmOps assign Secrets and ConfigMaps Sep 8, 2025
@torchiaf torchiaf force-pushed the 15344-pass-helm-ops-secrets-cms branch 5 times, most recently from 28caae6 to 66b9495 Compare September 11, 2025 08:01
@torchiaf torchiaf force-pushed the 15344-pass-helm-ops-secrets-cms branch from 66b9495 to 2b706f5 Compare October 15, 2025 16:05
@torchiaf torchiaf marked this pull request as ready for review October 15, 2025 16:05
@torchiaf torchiaf requested a review from cnotv October 15, 2025 16:05
@rancher-ui-project-bot rancher-ui-project-bot bot modified the milestones: v2.13.0, v2.14.0 Oct 15, 2025
Copy link
Member

@cnotv cnotv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything blocking.
LGTM

@torchiaf torchiaf merged commit 6cecad3 into rancher:master Oct 20, 2025
68 of 71 checks passed
@richard-cox
Copy link
Member

@torchiaf @cnotv this is a 2.14 issue but merged to 2.13. does it need reverting? if not please update issue and PR milestones

@cnotv
Copy link
Member

cnotv commented Nov 4, 2025

If this was breaking anything 2 weeks ago, I think that would be already visible somewhere. There must have been wrong milestones set.

@yonasberhe23 yonasberhe23 modified the milestones: v2.14.0, v2.13.0 Nov 6, 2025
@yonasberhe23
Copy link
Contributor

updated the PR milestone to 2.13 after confirming with @torchiaf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fleet pass secrets and config maps to workload cluster

4 participants