Skip to content

Conversation

@richard-cox
Copy link
Member

@richard-cox richard-cox commented Sep 4, 2025

Summary

Add a workflow to send a slack message if an issue milestone was changed from someone outside of rancher/ui

Technical notes summary

  • If the user is in rancher/ui then the request to check it should succeed
  • Check if the person who triggers the workflow is a member of rancher/ui
    • We can expand this to people outside of the team if required
  • If the request fails the a notification is sent to a new rancher Rancher UI - Milestone Changed workflow
    • Currently sends me a DM, i'll change this once everything is working fine
    • Added a repo secret SLACK_WORKFLOW_MILESTONE_CHANGED_URL

Areas or cases that should be tested

  • I've tested this in my fork
    • The check for membership always fails, i need to check it running from within this repo. have a feeling it won't work
    • The slack hook succesfully triggers the workflow and i get a DM with the correct values

TODO after merge

  • Validate slack message is sent correctly given team member or not
  • Change workflow to send a message to team channel instead of a DM to me

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility

@richard-cox richard-cox added this to the v2.13.0 milestone Sep 4, 2025
@nwmac nwmac modified the milestones: v2.13.0, v2.14.0 Oct 28, 2025
@richard-cox richard-cox removed the ci/skip-e2e Forcibly skip E2E tests in the CI label Nov 12, 2025
@richard-cox richard-cox requested a review from nwmac November 12, 2025 15:22
@richard-cox richard-cox marked this pull request as ready for review November 19, 2025 07:04
Copy link
Member

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richard-cox richard-cox merged commit b8ffb9c into master Nov 25, 2025
33 checks passed
@richard-cox richard-cox deleted the valid-pr-change branch November 25, 2025 11:12
@richard-cox
Copy link
Member Author

TODO:

  • Validate slack message is sent correctly given team member or not - FAIL always 40s, always sends DM
  • Change workflow to send a message to team channel instead of a DM to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants