Skip to content

Conversation

@ly5156
Copy link
Contributor

@ly5156 ly5156 commented Jun 30, 2025

Summary

Fixes #14637

The user lacks permission to access resource CAPI.RANCHER_CLUSTER or HCI.HARVESTER_CONFIG, resulting in an error when loading resource CAPI.RANCHER_CLUSTER or HCI.HARVESTER_CONFIG. Consequently, the updateMatchingPods method was not executed.

Occurred changes and/or fixed issues

Before loading resource CAPI.RANCHER_CLUSTER or HCI.HARVESTER_CONFIG , check for permissions.

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility

@richard-cox richard-cox added this to the v2.13.0 milestone Sep 17, 2025
@gaktive gaktive requested a review from rak-phillip October 31, 2025 16:15
@rak-phillip rak-phillip force-pushed the service-selector-matches-tip branch from efbbd97 to 6c8a534 Compare November 1, 2025 00:18
Copy link
Member

@rak-phillip rak-phillip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rak-phillip
Copy link
Member

@ly5156 FYI - this change was stuck on CI and I had to amend the commit to retrigger. I hope that this isn't a problem 🙂

@rak-phillip rak-phillip merged commit 51cf1dc into rancher:master Nov 1, 2025
60 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error in the number of match pods prompted on the create or edit page of the service

3 participants