Use nn_module_stack instead #3268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3268
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 14bc2c0 with merge base 315e9b4 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@tugsbayasgalan has exported this pull request. If you are a Meta employee, you can view the originating Diff in D85959415. |
angelayi
approved these changes
Oct 31, 2025
Contributor
angelayi
left a comment
There was a problem hiding this comment.
This should be equivalent!
andrewor14
reviewed
Oct 31, 2025
| node.target == torch.ops.aten.add_.Tensor | ||
| and node.args[0].op == "get_attr" | ||
| and node.args[1] == 1 | ||
| and torch.nn.modules.batchnorm.BatchNorm2d |
Contributor
There was a problem hiding this comment.
I think this needs to be a string instead according to this:
Summary: I don't know why source_fn_stack is disappeared but i think relying on nn_module_stack is better Reviewed By: angelayi Differential Revision: D85959415
e9796e1 to
14bc2c0
Compare
namgyu-youn
pushed a commit
to namgyu-youn/ao
that referenced
this pull request
Nov 21, 2025
Differential Revision: D85959415 Pull Request resolved: pytorch#3268
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: I don't know why source_fn_stack is disappeared but i think relying on nn_module_stack is better
Differential Revision: D85959415