Skip to content

Conversation

@vkuzo
Copy link
Contributor

@vkuzo vkuzo commented Oct 16, 2025

Summary:

as titled, extends the cast benchmarks for nvfp4

Test Plan:

// 0.8 TB/s (9% peak bandwidth)
python benchmarks/mx_formats/cast_bench.py --mode dim0_nvfp4
// 3.3 TB/s (42% peak bandwidth)
python benchmarks/mx_formats/cast_bench.py --mode dim0_nvfp4_triton_swizzle

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@vkuzo
Copy link
Contributor Author

vkuzo commented Oct 16, 2025

Stack from ghstack (oldest at bottom):

vkuzo added a commit that referenced this pull request Oct 16, 2025
Summary:

as titled, extends the cast benchmarks for nvfp4

Test Plan:

```bash
// 0.8 TB/s (9% peak bandwidth)
python benchmarks/mx_formats/cast_bench.py --mode dim0_nvfp4
// 3.3 TB/s (42% peak bandwidth)
python benchmarks/mx_formats/cast_bench.py --mode dim0_nvfp4_triton_swizzle
```

Reviewers:

Subscribers:

Tasks:

Tags:
ghstack-source-id: 8c5500b
ghstack-comment-id: 3410272031
Pull-Request: #3188
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 16, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3188

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit c3c9b07 with merge base 30082cb (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 16, 2025
@vkuzo vkuzo added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label Oct 16, 2025
bps = (bytes_r + bytes_w) / (time_us / 1e6)

elif mode == "dim0_nvfp4":
to_nvfp4_reference_c = torch.compile(to_nvfp4_reference)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you set fullgraph = True

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can do in a separate PR

@vkuzo vkuzo merged commit e8471c6 into main Oct 16, 2025
50 of 52 checks passed
namgyu-youn pushed a commit to namgyu-youn/ao that referenced this pull request Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing Use this tag if you don't want this PR to show up in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants