fix nvfp4 serialization #3140
Merged
fix nvfp4 serialization #3140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3140
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit fa786d1 with merge base c63899b ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
vkuzo
added a commit
that referenced
this pull request
Oct 10, 2025
Summary: Before this PR it only worked for nvfp4 weight-only, fixing to also make it work for nvfp4 dynamic. Test Plan: ```bash pytest test/prototype/mx_formats/test_inference_workflow.py -k test_inference_workflow_nvfp4 -x ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: b4f5197 ghstack-comment-id: 3387849325 Pull-Request: #3140
drisspg
approved these changes
Oct 10, 2025
namgyu-youn
pushed a commit
to namgyu-youn/ao
that referenced
this pull request
Nov 21, 2025
Update [ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Before this PR it only worked for nvfp4 weight-only, fixing to also make
it work for nvfp4 dynamic.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: