Disable Python 3.13 when building wheels for CI #909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keith Battocchi <[email protected]>
1f88903 to
c8950b4
Compare
fverac
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent release of
cibuildwheelhas started including python 3.13, butscipyhasn't published any 3.13 builds yet (and building from source isn't working due to a fortran compiler issue), so building wheels on 3.13 fails.That is fine for nightly builds, but bad for CI builds, where "last known good" should extend to versions of python as well as versions of our dependencies. This fixes that issue by tying which versions of python are used by cibuildwheel to whether we're considering LKG status or not.