Skip to content

fix bug in check_high_dimensional #906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kbattocchi merged 3 commits into from
Aug 14, 2024
Merged

fix bug in check_high_dimensional #906

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef7fbaf
fix bug in check_high_dimensional
itamarfaran Aug 5, 2024
a3efc11
add test_check_high_dimensional
itamarfaran Aug 12, 2024
07640c0
Merge branch 'main' into patch-1
kbattocchi Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion econml/utilities.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ def check_high_dimensional(X, T, *, threshold, featurizer=None, discrete_treatme
elif featurizer is None:
d_x = X.shape[1]
else:
d_x = clone(featurizer, safe=False).fit_transform(X[[0], :]).shape[1]
d_x = clone(featurizer, safe=False).fit_transform(X).shape[1]
if discrete_treatment:
d_t = len(set(T.flatten())) - 1
else:
Expand Down