Skip to content

Raise threshold to lower the failure rate for rootpehe value assertion. #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kbattocchi merged 5 commits into from
May 7, 2024
Merged

Raise threshold to lower the failure rate for rootpehe value assertion. #876

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
85a05fa
raise threshold to lower the failure rate rootpehe value assertion
kgao Apr 12, 2024
7821341
increase sample size to reduce errors
kgao May 6, 2024
9fe8a74
Rollback PEHE changes, keep it originally in the 0.1-0.25 range
kgao May 6, 2024
40584c9
Merge branch 'main' into fix_test_rscorer
kbattocchi May 7, 2024
0839618
Merge branch 'main' into fix_test_rscorer
kbattocchi May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions econml/tests/test_rscorer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ def clf():
assert LinearRegression().fit(np.array(rscore).reshape(-1, 1), np.array(rootpehe_score)).coef_ < 0.5
mdl, _ = scorer.best_model([mdl for _, mdl in models])
rootpehe_best = np.sqrt(np.mean((true_eff_val.flatten() - mdl.effect(X_val).flatten())**2))
assert rootpehe_best < 1.5 * np.min(rootpehe_score) + 0.05
assert rootpehe_best < 4 * np.min(rootpehe_score) + 0.5
mdl, _ = scorer.ensemble([mdl for _, mdl in models])
rootpehe_ensemble = np.sqrt(np.mean((true_eff_val.flatten() - mdl.effect(X_val).flatten())**2))
assert rootpehe_ensemble < 1.5 * np.min(rootpehe_score) + 0.05
assert rootpehe_ensemble < 4 * np.min(rootpehe_score) + 0.5