fix: support legacy V14 metadata outer enum naming #2154
Merged
+94
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thank you! Will look more closely tomorrow morning! |
Collaborator
|
This is great; just added a test (and tweaked decoding to help the test) and all looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds fallback lookup for legacy outer enum naming in V14 metadata conversion.
Older Substrate runtimes used
polkadot_runtime::Callandpolkadot_runtime::Eventinstead of the modern
RuntimeCallandRuntimeEventnames. This causedTypeNameNotFound("RuntimeCall")errors when working with historical blocks.The fix tries modern names first, then falls back to legacy
*_runtime::Call/Eventpatterns.I found this issue when integrating v0.50 into polkadot-rest-api. This fixed our issue.