-
Notifications
You must be signed in to change notification settings - Fork 4.8k
NE-2376: Remove restriction of unmanaged x-k8s.io #30658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Previously, cluster-ingress-operator would manage and block any
updates to CRDs that were from group gateway.networking.x-k8s.io.
After some analysis we identified that OSSM/Istio does filter these
resources in case it does not have a flag to enable alpha APIs, which means
it is safe to allow users to deploy these CRDs.
This way, this change removes any restriction on x-k8s.io group,
and removes any further reconciliation from CIO on x-k8s.io group.
Signed-off-by: Ricardo Pchevuzinske Katz <[email protected]>
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
|
@rikatz: This pull request references NE-2376 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rikatz The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/hold |
|
/test okd-scos-images |
|
/hold cancel |
|
@rikatz: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Previously, cluster-ingress-operator would manage and block any
updates to CRDs that were from group gateway.networking.x-k8s.io.
After some analysis we identified that OSSM/Istio does filter these
resources in case it does not have a flag to enable alpha APIs, which means
it is safe to allow users to deploy these CRDs.
This way, this change removes any restriction on x-k8s.io group,
and removes any further reconciliation from CIO on x-k8s.io group.