-
Notifications
You must be signed in to change notification settings - Fork 197
Add a command for reviewing e2e test PRs and enforcing conventions #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dgoodwin
wants to merge
19
commits into
openshift-eng:main
Choose a base branch
from
dgoodwin:test-pr-reviewer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+710
−2
Open
Changes from 17 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
db438f1
Begin on openshift:test-review command to analyze test changes for co…
dgoodwin e63a898
Ensure new tests map to a component
dgoodwin 231e07d
Attempt to check if the test should be serial or not
dgoodwin 6788207
Support reviewing test code in github PRs
dgoodwin a11a921
Use zero to hero guide as context during the review
dgoodwin d57dbd4
Merge remote-tracking branch 'up/main' into test-pr-reviewer
dgoodwin 77fb386
Detect Owner and LEVEL0 in test names
dgoodwin aabe3b5
More checks and some clarifications
dgoodwin d739947
Use local repo when reviewing prs if available
dgoodwin ff65bfa
Better test guidelines doc download
dgoodwin fec7a33
Jira tag for new tests, allow sig/bz for modified
dgoodwin c710cdc
Simpler new/modified test detection
dgoodwin 516fbb5
Move to ci:pr-review command
dgoodwin 98a88a5
Rename to pr-test-analysis to differentiate from generic pr review
dgoodwin 4b56acf
Link for how to run additional test jobs
dgoodwin fa816e9
Add advice on use of /payload commands
dgoodwin 095f869
Start prepping for advice on additional testing
dgoodwin e106282
Merge remote-tracking branch 'up/main' into test-pr-reviewer
dgoodwin 7c5ecbd
make update
dgoodwin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.