Fix metrics temporality env var interpolation in docker-compose #2885
+17
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2884
The
docker-compose.ymluses the syntax- OTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCEwhich passes the variable from the shell environment, not from the.envfile. When the shell doesn't have this variable set, Docker Compose doesn't apply the.envvalue - instead, the value baked into the container images (delta) takes precedence. See reference on how environment variable interpolation works with .env files.This causes Prometheus to reject metrics with "invalid temporality and type combination" errors, affecting HTTP/RPC server metrics from most services.
Changes
Changed all occurrences from:
- OTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCETo explicit interpolation:
- OTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCE=${OTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCE}Test plan
make startdocker exec cart env | grep TEMPORALITYshowscumulativedocker logs prometheus 2>&1 | grep "invalid temporality"shows no errors