Skip to content

[accounting] move dbcontext to local scope - fix memory leak #2876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julianocosta89 merged 2 commits into from
Jan 12, 2026
Merged

[accounting] move dbcontext to local scope - fix memory leak #2876

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05840e4
move dbcontext to local scope
puckpuck Jan 9, 2026
bdd8859
accounting - fix memory leak
puckpuck Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ the release.

## Unreleased

* [accounting] fix memory leak with dbcontext
([#2876](https://github.com/open-telemetry/opentelemetry-demo/pull/2876))

## 2.2.0

* [feat] add ipv6 support
Expand Down
15 changes: 8 additions & 7 deletions src/accounting/Consumer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ internal class Consumer : IDisposable
private ILogger _logger;
private IConsumer<string, byte[]> _consumer;
private bool _isListening;
private DBContext? _dbContext;
private readonly string? _dbConnectionString;
private static readonly ActivitySource MyActivitySource = new("Accounting.Consumer");

public Consumer(ILogger<Consumer> logger)
Expand All @@ -49,7 +49,7 @@ public Consumer(ILogger<Consumer> logger)
_logger.LogInformation("Connecting to Kafka: {servers}", servers);
}

_dbContext = Environment.GetEnvironmentVariable("DB_CONNECTION_STRING") == null ? null : new DBContext();
_dbConnectionString = Environment.GetEnvironmentVariable("DB_CONNECTION_STRING");
}

public void StartListening()
Expand Down Expand Up @@ -90,16 +90,17 @@ private void ProcessMessage(Message<string, byte[]> message)
var order = OrderResult.Parser.ParseFrom(message.Value);
Log.OrderReceivedMessage(_logger, order);

if (_dbContext == null)
if (_dbConnectionString == null)
{
return;
}

using var dbContext = new DBContext();
var orderEntity = new OrderEntity
{
Id = order.OrderId
};
_dbContext.Add(orderEntity);
dbContext.Add(orderEntity);
foreach (var item in order.Items)
{
var orderItem = new OrderItemEntity
Expand All @@ -112,7 +113,7 @@ private void ProcessMessage(Message<string, byte[]> message)
OrderId = order.OrderId
};

_dbContext.Add(orderItem);
dbContext.Add(orderItem);
}

var shipping = new ShippingEntity
Expand All @@ -128,8 +129,8 @@ private void ProcessMessage(Message<string, byte[]> message)
ZipCode = order.ShippingAddress.ZipCode,
OrderId = order.OrderId
};
_dbContext.Add(shipping);
_dbContext.SaveChanges();
dbContext.Add(shipping);
dbContext.SaveChanges();
}
catch (Exception ex)
{
Expand Down