Revert pr #19290 to tempoararily add back broken sapi4 while we move it to the 32 bit runtime #19436
+1,649
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 33cf7ad.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR is a clean revert of PR #19290, which previously removed SAPI 4 support from NVDA. The revert is temporary—SAPI 4 is being restored so that PR #19432 can move it to a 32-bit runtime environment. Since SAPI 4 only functions in 32-bit processes and NVDA has moved to 64-bit, this intermediate step is necessary.
Changes:
- Reverts the removal of SAPI 4 synthesizer driver code
- Re-adds SAPI 4 documentation to user guide and design docs
- Restores WASAPI configuration option for SAPI 4
- Resolves conflicts in changes.md (though with an error—see below)
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| user_docs/en/userGuide.md | Restored SAPI 4 synthesizer documentation and WASAPI configuration option description |
| user_docs/en/changes.md | Removed changelog entries about SAPI 4 removal (conflict resolution has errors) |
| source/synthDrivers/sapi4.py | Restored SAPI 4 synthesizer driver implementation (~1260 lines) |
| source/synthDrivers/_sapi4.py | Restored SAPI 4 COM interface definitions (~332 lines) |
| source/gui/settingsDialogs.py | Re-added WASAPI for SAPI 4 GUI controls in Advanced settings |
| source/config/configSpec.py | Restored useWASAPIForSAPI4 configuration option |
| projectDocs/design/synthesizers.md | Added new documentation for testing SAPI 4 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
seanbudd
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Reverts #19290
Summary of the issue:
with the move to 64 bit, sapi4 became unusable as it only functions in a 32 bit process. PR #19290 was merged which removes sapi4. However, pr #19432 is adding the infrastructure to run sapi4 within a 32 bit runtime. Thus the original sapi4 should be tempoararily added back so that pr #19432 can move it into its 32 bit location.
Description of user facing changes:
None.
Description of developer facing changes:
Description of development approach:
This is a clean revert of pr #19290 (with only a conflict in changes.md which was addressed).
Testing strategy:
None - clean revert.
Known issues with pull request:
None known.
Code Review Checklist: