Skip to content

fix up pre-commit for xliff files #19426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
seanbudd wants to merge 2 commits into
base: beta
Choose a base branch
from
+2 −2
Draft

fix up pre-commit for xliff files #19426

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5f83dc
fix up pre-commit for xliff files
seanbudd Jan 9, 2026
a6c6b6e
Update .pre-commit-config.yaml
seanbudd Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ repos:
args: ["--branch", "master", "--branch", "beta", "--branch", "rc"]
# Checks that large files have not been added. Default cut-off for "large" files is 500kb.
- id: check-added-large-files
# POFiles and TTF fonts can't be made smaller
exclude_types: ["pofile", "ttf"]
# POFiles, TTF fonts, and xliff files can't be made smaller
exclude_types: ["pofile", "ttf", ".xliff"]
Copy link

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The exclude_types syntax is incorrect. The 'identify' library used by pre-commit recognizes file types without the leading dot. According to the pattern used for 'pofile' and 'ttf' (which also don't have dots), this should be 'xliff' instead of '.xliff'. The leading dot will prevent the exclusion from working correctly, and xliff files will still be checked for size, causing the pre-commit hook to fail.

Suggested change
exclude_types: ["pofile", "ttf", ".xliff"]
exclude_types: ["pofile", "ttf", "xliff"]

Copilot uses AI. Check for mistakes.
Copy link
Member Author

@seanbudd seanbudd Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xliff isn't here I'll have to use exclude instead possibly

Copy link
Member Author

@seanbudd seanbudd Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opened pre-commit/identify#558

# Same applies for NVDA dictionary (.dic) files and Spline Font Database (.SFD) files, but these aren't recognised by the Identify library.
exclude: "\\.(dic|sfd)$"
# Checks python syntax
Expand Down
Loading