Magnifier implementation #19228
Magnifier implementation #19228
Conversation
f5a86b5 to
7b3ee4f
Compare
|
I think the behaviour with screen curtain is whatever gets activated should just deactivate the other. However, in settings, we need to make sure both aren't activated at the same time. We should add checks when saving settings to ensure NVDA won't start trying to enable both screen curtain and magnifier. When enabling each, check if the other is active, and if so, disable it. |
|
Actually I think the behaviour with screen curtain as you've designed is fine for now. It ensures the person intentionally wants to deactivate screen curtain. |
seanbudd
left a comment
There was a problem hiding this comment.
Thanks @Boumtchack, the docs here are really good. I've reviewed everything except the tests
Why? I have tried to describe a valid use case in #19228 (comment), where screen curtain would be enabled for a short time while Magnifier is already active. Note that I have not tested last devs of @Boumtchack against that use case. |
|
@CyrilleB79 - did you miss my follow up message #19228 (comment)
|
Oh sorry, OK. From my quick reading of the description it sounds fine. |
|
|
||
| ##### Default focus mode {#MagnifierDefaultFocusMode} | ||
|
|
||
| | . {.hideHeaderRow} |.| |
There was a problem hiding this comment.
please move this to below the summary paragraph, but above the other table
|
|
||
| ##### Default color filter {#MagnifierDefaultFilter} | ||
|
|
||
| | . {.hideHeaderRow} |.| |
There was a problem hiding this comment.
please move this to below the summary paragraph, but above the other table
user_docs/en/userGuide.md
Outdated
|
|
||
| ##### Default zoom level {#MagnifierDefaultZoom} | ||
|
|
||
| | . {.hideHeaderRow} |.| |
There was a problem hiding this comment.
please move this to the bottom of the section
user_docs/en/userGuide.md
Outdated
| |Options |Default (Enabled), Disabled, Enabled | | ||
| |Default |Enabled | |
There was a problem hiding this comment.
please make sure to list the actual options and defaults
user_docs/en/userGuide.md
Outdated
|
|
||
| ##### Keep mouse centered {#MagnifierKeepMouseCentered} | ||
|
|
||
| | . {.hideHeaderRow} |.| |
There was a problem hiding this comment.
please move this to the bottom of the section
Link to issue number:
Closes #12539
Summary of the issue:
This pull request introduces a new NVDA magnifier feature, including docked and lens magnifier modes, color filter support, and a set of global commands for controlling magnification. The changes add new classes for handling magnifier windows, provide optimized color filtering, and implement keyboard shortcuts for toggling magnification, zooming, cycling modes, and color filters.
Description of user facing changes:
Implemented new script commands in globalCommands.py for starting/stopping the magnifier, zooming in/out, cycling color filters, toggling fullscreen mode, cycling magnifier types, and spotlighting the magnifier window, each with descriptive messages and gestures.
Description of developer facing changes:
Description of development approach:
Creating 3 types of magnifier that will be called based on prefered choice of the user. each one got his class and will share settings through parents class
Testing strategy:
unit test
Known issues with pull request:
Code Review Checklist: