Fixup MathCAT settings

[codeofdusk]

Link to issue number:

Follow-up of #18323.

Summary of the issue:

Some MathCAT options were unclear and hard to understand.

Description of how this pull request fixes the issue:

Cleanup UI and documentation.

Testing strategy:

Tested that settings changes appear as expected. Alpha testing.

Known issues with pull request:

None known

Code Review Checklist:

• Documentation:
  • Change log entry
  • User Documentation
  • Developer / Technical Documentation
  • Context sensitive help for GUI changes
• Testing:
  • Unit tests
  • System (end to end) tests
  • Manual testing
• UX of all users considered:
  • Speech
  • Braille
  • Low Vision
  • Different web browsers
  • Localization in other languages / culture than English
• API is compatible with existing add-ons.
• Security precautions taken.

[LeonarddeR]

I got the following error when opening the math category in settings:

ERROR - unhandled exception (11:21:34.782) - MainThread (19336):
Traceback (most recent call last):
  File "mathPres\MathCAT\localization.pyc", line 349, in getSpeechStyleFromDirectory
  File "zipfile\__init__.pyc", line 1367, in __init__
FileNotFoundError: [Errno 2] No such file or directory: 'C:\\Program Files\\NVDA\\include\\nvda-mathcat\\assets\\Rules\\Languages\\nl\\nl.zip'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "gui\settingsDialogs.pyc", line 6050, in onCategoryChange
  File "gui\settingsDialogs.pyc", line 748, in onCategoryChange
  File "gui\settingsDialogs.pyc", line 730, in _doCategoryChange
  File "gui\settingsDialogs.pyc", line 657, in _getCategoryPanel
  File "gui\settingsDialogs.pyc", line 389, in __init__
  File "gui\settingsDialogs.pyc", line 399, in _buildGui
  File "gui\settingsDialogs.pyc", line 2839, in makeSettings
  File "mathPres\MathCAT\preferences.pyc", line 259, in getSpeechStyleChoicesWithTranslations
  File "mathPres\MathCAT\localization.pyc", line 369, in getSpeechStyles
  File "mathPres\MathCAT\localization.pyc", line 354, in getSpeechStyleFromDirectory
UnboundLocalError: cannot access local variable 'zipFile' where it is not associated with a value

Is this also covered?

[codeofdusk]

I got the following error when opening the math category in settings

I also run into this when running master builds from source – it's unrelated to this PR. Binary builds work fine.

[LeonarddeR]

I was running with latest alpha.

[codeofdusk]

@LeonarddeR As it turns out, that was an unrelated issue, which is also fixed in this PR.

[codeofdusk]

CC @RyanMcCleary, @seanbudd.

[codeofdusk]

@SaschaCowley I've fixed up this PR and rebased on beta; it's ready for review.

[seanbudd]

In future, please avoid force pushes. It means we have to review the entire PR from scratch

[seanbudd]

Thanks @codeofdusk . This is all good from me, but I'd like to wait for @Qchristensen to get back from leave to review and merge this, so this may have to hold off until next year.

[codeofdusk]

CC @Qchristensen.

[Qchristensen]

UserGuide reads well - sorry for making you wait!