-
-
Notifications
You must be signed in to change notification settings - Fork 46
feat: pipe operators #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: pipe operators #159
Conversation
|
I'm curious if there's any reason this hasn't been merged yet? Also curious if anyone's had any success using this fork in |
|
No one prioritized it. I think this is just a quick review. |
|
This is not trying to block a merge, but I think it's an important policy/philosophical question to answer: |
|
Re the pipe operator itself (irrelevant to the overall merging or not of this PR): |
Just a few more operators won't hurt anything. If the feature gets aborted upstream, it's also pretty easy to revert this. |
It's irrelevant if it's experimental or not. A parser/query/lsp is a reactive optional tooling that needs to know how the language works now. Its inclusion should have no effect on the stabilization. If nix reverts the feature there is no drastic side effect to treesitter parser finding significance in 2 characters being next to each other. The flip side opinion would be how you can you properly evaluate an experimental feature if you never update tooling to work with it. |
@adisbladis I would love to discuss an issue like that, and honestly I have very little stake in the outcome here. I've just been relatively annoyed by the errors I get in Neovim when I use the pipe operators. :) That being said, since starting a discussion about the merits of an experimental feature here might drown the work that @mightyiam did to make this PR, is there a place where I (we?) can read more about your thoughts on pipe operators and what you dislike about them? I find that understanding the opinions of more experienced developers with different perspectives than my own is one of the quickest ways for me to learn. |
Closes #83