Skip to content

data modeling - fix f-string bug and github actions bug #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
a-s-g93 merged 2 commits into from
Dec 22, 2025
Merged

data modeling - fix f-string bug and github actions bug #260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a92a22
fix f-string bug and github actions bug
a-s-g93 Dec 22, 2025
9d959cb
Update CHANGELOG.md
a-s-g93 Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pr-mcp-neo4j-data-modeling.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
- name: Install dependencies
run: |
cd servers/mcp-neo4j-data-modeling
uv venv
uv venv --python ${{ matrix.python-version }}
uv pip install -e ".[dev]"

- name: Check format and linting
Expand Down
2 changes: 2 additions & 0 deletions servers/mcp-neo4j-data-modeling/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
## Next

### Fixed
* Fixed bug in f-string formatting with Pydantic model export in Python v < 3.12
* Fixed bug in the data modeling Github action that didn't actually test different Python versions due to not specifying the version when executing uv commands.

### Changed

Expand Down
8 changes: 6 additions & 2 deletions servers/mcp-neo4j-data-modeling/src/mcp_neo4j_data_modeling/data_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,10 +368,12 @@ def to_pydantic_model_str(self) -> str:
escaped_desc = self.description.replace('"""', r"\"\"\"")
docstring = f'\n """{escaped_desc}"""'

# Extract newline to avoid backslash in f-string
props_joined = "\n ".join(props)
return f"""class {self.label}(BaseModel):{docstring}
node_label: ClassVar[str] = \"{self.label}\"

{"\n ".join(props)}"""
{props_joined}"""

def to_neo4j_graphrag_python_package_node_dict(self) -> dict[str, str]:
"""
Expand Down Expand Up @@ -661,7 +663,9 @@ def to_pydantic_model_str(
docstring = f'\n """{escaped_desc}"""'

# Build properties section with proper indentation
props_section = f"\n {'\n '.join(props)}\n" if props else ""
# Extract newline to avoid backslash in f-string
props_joined = '\n '.join(props)
props_section = f"\n {props_joined}\n" if props else ""

return f"""class {type_pascal_case}(BaseModel):{docstring}
relationship_type: ClassVar[str] = \"{self.type}\"
Expand Down