Skip to content

[internal] Remove duplicate eslint rule #4559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oliviertassinari wants to merge 4 commits into
base: master
Choose a base branch
from
+9 −40
Open

[internal] Remove duplicate eslint rule #4559

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4fa09eb
[core] Remove duplicate eslint rule
oliviertassinari Dec 26, 2024
31f9c7e
one more
oliviertassinari Dec 26, 2024
11b95da
no longer an issue
oliviertassinari Dec 26, 2024
d82e6e3
sort
oliviertassinari Dec 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 0 additions & 23 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,29 +108,6 @@ module.exports = {
files: ['**/*.test.js', '**/*.test.ts', '**/*.test.tsx'],
extends: ['plugin:testing-library/react'],
},
{
files: ['docs/src/modules/components/**/*.js'],
Copy link
Member Author

@oliviertassinari oliviertassinari Dec 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed, duplicate with

toolpad/.eslintrc.js

Line 102 in 4fa09eb

'material-ui/no-hardcoded-labels': 'off', // We are not really translating the docs/website anymore

rules: {
'material-ui/no-hardcoded-labels': 'off',
},
},
{
/**
* TODO move to @mui/monorepo
*
* Examples are for demostration purposes and should not be considered as part of the library.
* They don't contain an eslint setup, so we don't want them to contain eslint directives
* We do however want to keep the rules in place to ensure the examples are following
* a reasonably similar code style as the library.
*/
files: ['examples/**/*'],
Copy link
Member Author

@oliviertassinari oliviertassinari Dec 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed, duplicates with https://github.com/mui/material-ui/blob/060c55cb219bfc33633f7e61484884ea6d37bfdf/.eslintrc.js#L529

rules: {
'no-console': 'off',
'no-underscore-dangle': 'off',
// no node_modules in examples as they are not installed
'import/no-unresolved': 'off',
},
},
{
files: [
'packages/create-toolpad-app/**/*',
Expand Down
Loading