Skip to content

Conversation

@oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Nov 1, 2024

I noticed this in: https://github.com/mui/toolpad/pull/4344/files#r1826369440.

I didn't look at how this can be replicated on the next docs-infra structure, but at least, in the meantime, we will make sure it's done right, less migration effort. I opened mui/toolpad#4351 and mui/mui-x#15229 to make it easier for those repositories to upgrade docs-infra with this PR in.

@oliviertassinari oliviertassinari added type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. scope: docs-infra Involves the docs-infra product (https://www.notion.so/mui-org/b9f676062eb94747b6768209f7751305). labels Nov 1, 2024
@mui-bot
Copy link

mui-bot commented Nov 1, 2024

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 9ba44d3

@bharatkashyap bharatkashyap changed the title [docs-infra] Enforce ponctuation on descriptions [docs-infra] Enforce punctuation on descriptions Nov 2, 2024
@oliviertassinari
Copy link
Member Author

Merging, this seems non-controversial. I have added point 22. in mui/base-ui#588 to keep some track of this, so all good 😁

@oliviertassinari oliviertassinari merged commit c1d82a3 into mui:master Nov 9, 2024
@oliviertassinari oliviertassinari deleted the description-dot branch November 9, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: docs-infra Involves the docs-infra product (https://www.notion.so/mui-org/b9f676062eb94747b6768209f7751305). type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants