Skip to content
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions .editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,9 @@
# top-most EditorConfig file
root = true

[*.md]
trim_trailing_whitespace = false

[*.js]
trim_trailing_whitespace = true

# Unix-style newlines with a newline ending every file
[*]
trim_trailing_whitespace = true
indent_style = space
indent_size = 2
end_of_line = lf
Expand Down
3 changes: 0 additions & 3 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@
.idea
# IntelliJ IDEA module file
*.iml
.vscode/*
!.vscode/launch.json
!.vscode/extensions.json
*.log
*.tsbuildinfo
/.eslintcache
Expand Down
22 changes: 16 additions & 6 deletions .vscode/extensions.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,20 @@
{
"recommendations": [
"davidanson.vscode-markdownlint",
"dbaeumer.vscode-eslint",
"editorconfig.editorconfig",
"esbenp.prettier-vscode",
"unifiedjs.vscode-mdx",
"yoavbls.pretty-ts-errors"
// Formating
"esbenp.prettier-vscode", // Prettier
"editorconfig.editorconfig", // EditorConfig

// Highlighting
"bradlc.vscode-tailwindcss", // Tailwind CSS
"unifiedjs.vscode-mdx", // MDX
"shardulm94.trailing-spaces", // Trailing spaces
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prettier does it

"styled-components.vscode-styled-components", // styled()

// Lint
"dbaeumer.vscode-eslint", // ESLint
"yoavbls.pretty-ts-errors", // TypeScript
"stylelint.vscode-stylelint", // Stylelint
"davidanson.vscode-markdownlint", // markdownlint
"chrischinchilla.vale-vscode" // Vale
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure about Vale. It's useful for us, but the extension is not standalone (requires installing Vale separately), which could be worse DX for external contributors.

]
}
15 changes: 0 additions & 15 deletions .vscode/launch.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

This file was deleted.

14 changes: 14 additions & 0 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
{
"editor.defaultFormatter": "esbenp.prettier-vscode",
"files.trimTrailingWhitespace": true,

// Root workspace only
"typescript.tsdk": "node_modules/typescript/lib",
"typescript.surveys.enabled": false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we want to enforce this?

"grammarly.selectors": [
{
"language": "markdown",
"scheme": "file"
}
]
}
Loading