Skip to content

Fix: Disable window shadows on macOS Tahoe to prevent GPU performance issues #267724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deepak1556 merged 3 commits into from
Sep 24, 2025
Merged

Fix: Disable window shadows on macOS Tahoe to prevent GPU performance issues #267724

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
830c926
fix: disable window shadows on macOS Tahoe to prevent GPU performance…
avarayr Sep 22, 2025
21c7328
chore: clarify comment
avarayr Sep 22, 2025
815a9bd
chore: cleanup
deepak1556 Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/vs/base/common/platform.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,3 +278,7 @@ export const isAndroid = !!(userAgent && userAgent.indexOf('Android') >= 0);
export function isBigSurOrNewer(osVersion: string): boolean {
return parseFloat(osVersion) >= 20;
}

export function isTahoe(osVersion: string): boolean {
return parseFloat(osVersion) === 25;
}
11 changes: 10 additions & 1 deletion src/vs/platform/windows/electron-main/windows.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,11 @@
*--------------------------------------------------------------------------------------------*/

import electron, { Display, Rectangle } from 'electron';
import { release } from 'os';
import { Color } from '../../../base/common/color.js';
import { Event } from '../../../base/common/event.js';
import { join } from '../../../base/common/path.js';
import { IProcessEnvironment, isLinux, isMacintosh, isWindows } from '../../../base/common/platform.js';
import { IProcessEnvironment, isLinux, isMacintosh, isTahoe, isWindows } from '../../../base/common/platform.js';
import { URI } from '../../../base/common/uri.js';
import { IAuxiliaryWindow } from '../../auxiliaryWindow/electron-main/auxiliaryWindow.js';
import { IConfigurationService } from '../../configuration/common/configuration.js';
Expand Down Expand Up @@ -186,6 +187,14 @@ export function defaultBrowserWindowOptions(accessor: ServicesAccessor, windowSt
if (windowSettings?.clickThroughInactive === false) {
options.acceptFirstMouse = false;
}

// Mac OS 26.?.? has a `WindowServer` bug that causes (some?) windows with shadows
// to cause 80%+ GPU load.
// See: https://github.com/electron/electron/issues/48311
// TODO: once the bug is fixed in the OS, lock this into a specific version.
if (isTahoe(release())) {
options.hasShadow = false;
}
}

if (overrides?.disableFullscreen) {
Expand Down
Loading