RSAOAEP: Add support for passing labels #27
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karianna
approved these changes
Dec 23, 2024
qmuntal
requested changes
Dec 24, 2024
Comment on lines
+114
to
+120
| if len(plaintext) < len(labelHash) { | ||
| return nil, errors.New("invalid ciphertext: missing label hash") | ||
| } | ||
| // Extract and verify the label hash | ||
| if !bytes.Equal(plaintext[:len(labelHash)], labelHash) { | ||
| return nil, errors.New("invalid label hash") | ||
| } |
Member
There was a problem hiding this comment.
(Almost) never use bytes.Equal in crypto code, as it is vulnerable to oracle side channel attacks. Use suble.ConstantTimeCompare. Also, don't short-circuit if the length are not equal, for the same reason.
| } | ||
| } | ||
|
|
||
| func TestRSAEncryptDecryptOAEP(t *testing.T) { |
Member
There was a problem hiding this comment.
Test that upstream crypto/rsa can decrypt ciphertexts (with labels) generated by us and vice-versa.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #22