-
Notifications
You must be signed in to change notification settings - Fork 913
Users/rishabhmalik/containerprovider #5447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
+894
−255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ption | Updated Test runner code to run container tests
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
….com/microsoft/azure-pipelines-agent into users/rishabhmalik/containerprovider
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR addresses Azure Pipelines Agent container node selection process and implements a comprehensive strategy pattern for Node.js version selection in container environments.
AB#2343104
AB#2343431
AB#2345319
AB#2345320
AB#2345321
Description
SelectNodeVersionForHostAsync()andSelectNodeVersionForContainer()ContainerOperationProviderwith proper node path detectionContainerOperationProvider.Risk Assessment (Low / Medium / High)
Medium Risk - This change affects the core node selection logic for container execution. However, risk is mitigated by:
AGENT_USE_NODE_STRATEGY)Unit Tests Added or Updated (Yes / No)
Additional Testing Performed
List manual or automated tests performed beyond unit tests (e.g., integration, scenario, regression).
Change Behind Feature Flag (Yes / No)
Yes - The change can be controlled via existing feature mechanisms:
AGENT_USE_NODE_STRATEGYcontrols strategy vs legacy behaviorTech Design / Approach
Documentation Changes Required (Yes/No)
Indicate whether related documentation needs to be updated.
Logging Added/Updated (Yes/No)
Telemetry Added/Updated (Yes/No)
Rollback Scenario and Process (Yes/No)
Dependency Impact Assessed and Regression Tested (Yes/No)