Skip to content

Add retries to docker login to handle flakiness with docker container #3840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mastrzyz wants to merge 6 commits into from
Closed

Add retries to docker login to handle flakiness with docker container #3840

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bbd4669
with retries.
May 19, 2022
71f855d
updated.
May 19, 2022
736893b
const.
May 19, 2022
95a651c
updated.
May 19, 2022
2a617ce
Merge branch 'master' into master
May 19, 2022
7ea7c2a
nit.
Jan 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 26 additions & 2 deletions src/Agent.Worker/ContainerOperationProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,8 +191,32 @@ private async Task PullContainerAsync(IExecutionContext executionContext, Contai
ArgUtil.NotNullOrEmpty(username, nameof(username));
ArgUtil.NotNullOrEmpty(password, nameof(password));

int loginExitCode = await _dockerManger.DockerLogin(executionContext, registryServer, username, password);
if (loginExitCode != 0)

// login with retry up to 3 times
int maxRetries = 3;
int retryCount = 0;
int loginExitCode = 0;

while (retryCount < maxRetries)
{
loginExitCode = await _dockerManger.DockerLogin(executionContext, registryServer, username, password);
if (loginExitCode == 0)
{
break;
}
else
{
retryCount++;
if (retryCount < maxRetries)
{
var backOff = BackoffTimerHelper.GetRandomBackoff(TimeSpan.FromSeconds(1), TimeSpan.FromSeconds(10));
executionContext.Warning($"Docker login failed with exit code {pullExitCode}, back off {backOff.TotalSeconds} seconds before retry.");
await Task.Delay(backOff);
}
}
}

if (retryCount == maxRetries && pullExitCode != 0)
{
throw new InvalidOperationException($"Docker login fail with exit code {loginExitCode}");
}
Expand Down