Skip to content

Add an agent knob that allows to specify driver when creating docker network #3751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rumyax merged 7 commits into from
Feb 18, 2022
Merged

Add an agent knob that allows to specify driver when creating docker network #3751

rumyax merged 7 commits into from
Feb 18, 2022

Conversation

@rumyax
Copy link
Contributor

@rumyax rumyax commented Feb 17, 2022 •
edited
Loading

Description: this pull request provides an implementation of new logic that allows to specify driver when creating docker network via the AZP_AGENT_DOCKER_NETWORK_CREATE_DRIVER environment variable (agent knob).

ChangeLog:

  • src/Agent.Sdk/Knob/AgentKnobs.cs — new agent konb is added
  • src/Agent.Worker/Container/DockerCommandManager.cs — using of specified driver is implemented

Tested these changes end-to-end manually in the following cases:

  • If the AZP_AGENT_DOCKER_NETWORK_CREATE_DRIVER agent knob is NOT specified, the agent behavior remains the same.
  • If this agent knob is specified and such driver actually exists, it will be used.
  • If this agent knob is specified but such driver does not exist, a default driver will be used. Warning about this can be found in the agent diagnostic logs and in the pipeline run logs.

Related issue

@rumyax rumyax marked this pull request as draft February 17, 2022 08:26
@rumyax rumyax changed the title Add an agent knob that allows to use nat driver when creating docker network Add an agent knob that allows to choose driver when creating docker network Feb 17, 2022
@rumyax rumyax added the bug label Feb 17, 2022
@rumyax rumyax changed the title Add an agent knob that allows to choose driver when creating docker network Add an agent knob that allows to specify driver when creating docker network Feb 17, 2022
@rumyax rumyax marked this pull request as ready for review February 17, 2022 11:34
@rumyax rumyax requested a review from a team February 17, 2022 12:00
@DaniilShmelev DaniilShmelev requested a review from a team February 18, 2022 06:23
@rumyax rumyax merged commit 1e520d2 into master Feb 18, 2022
@hez2010 hez2010 mentioned this pull request Mar 25, 2022
Merged
This was referenced Oct 17, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@localconst localconst localconst approved these changes

@DaniilShmelev DaniilShmelev DaniilShmelev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rumyax @localconst @DaniilShmelev