Skip to content

fix(graph): using assignment expression to avoid repeated function call #1174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
you-n-g merged 2 commits into from
Aug 13, 2025
Merged

fix(graph): using assignment expression to avoid repeated function call #1174

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6d56ca
using assignment expression to avoid repeated function call
chaosddp Aug 12, 2025
a4e7c82
format
chaosddp Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions rdagent/components/knowledge_management/graph.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,10 +136,10 @@ def add_node(
-------

"""
if self.get_node(node.id):
node = self.get_node(node.id)
elif self.find_node(content=node.content, label=node.label):
node = self.find_node(content=node.content, label=node.label)
if tmp_node := self.get_node(node.id):
node = tmp_node
elif tmp_node := self.find_node(content=node.content, label=node.label):
node = tmp_node
else:
# same_node = self.semantic_search(node=node.content, similarity_threshold=same_node_threshold, topk_k=1)
# if len(same_node):
Expand All @@ -150,10 +150,10 @@ def add_node(
self.nodes.update({node.id: node})

if neighbor is not None:
if self.get_node(neighbor.id):
neighbor = self.get_node(neighbor.id)
elif self.find_node(content=neighbor.content, label=node.label):
neighbor = self.find_node(content=neighbor.content, label=node.label)
if tmp_neighbor := self.get_node(neighbor.id):
neighbor = tmp_neighbor
elif tmp_neighbor := self.find_node(content=neighbor.content, label=node.label):
neighbor = tmp_neighbor
else:
# same_node = self.semantic_search(node=neighbor.content,
# similarity_threshold=same_node_threshold, topk_k=1)
Expand Down