Skip to content

fix: prevent parallelism in feedback and record steps #1046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
you-n-g merged 1 commit into from
Jul 9, 2025
Merged

fix: prevent parallelism in feedback and record steps #1046

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions rdagent/utils/workflow/loop.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,9 +136,12 @@ def get_semaphore(self, step_name: str) -> asyncio.Semaphore:
if isinstance(limit := RD_AGENT_SETTINGS.step_semaphore, dict):
limit = limit.get(step_name, 1) # default to 1 if not specified

# NOTE: we assume the record step is always the last step to modify the global environment,
# so we set the limit to 1 to avoid race condition
if step_name == "record":
# NOTE:
# (1) we assume the record step is always the last step to modify the global environment,
# so we set the limit to 1 to avoid race condition
# (2) Because we support (-1,) as local selection; So it is hard to align a) the comparision target in `feedbck`
# and b) parent node in `record`; So we prevent parallelism in `feedback` and `record` to avoid inconsistency
if step_name in ("record", "feedback"):
limit = 1

if step_name not in self.semaphores:
Expand Down