fix: scheduler next selection parallel disorder #1028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a96ab1b to
ee330f0
Compare
xuangu-fang
reviewed
Jul 8, 2025
Collaborator
There was a problem hiding this comment.
will this change affect other cases which don't use async?
xuangu-fang
reviewed
Jul 8, 2025
| while True: | ||
| # step 0: Commit the pending selections | ||
| for i in range(self.rec_commit_idx, len(trace.dag_parent)): | ||
| for p in trace.dag_parent[i]: |
Collaborator
There was a problem hiding this comment.
trace.dag_parent[i] is a single-element tuple now, is the for-loop here prepared for multi-pararnt case in future? If so, what if a parant have multi-children, and we will have duplicate operations on it
efe2920 to
7a0e1ef
Compare
Contributor
Author
|
Tested under such setting. |
licong01-cloud
pushed a commit
to licong01-cloud/RD-Agent
that referenced
this pull request
Dec 13, 2025
* fix: improve scheduler API (suggest_sel) and add timer.remain_time() * chore: exclude .venv from auto-black and auto-isort tasks * refactor: wrap RoundRobinScheduler commit and selection in retry loop * set search_type="ancestors" for experiment_and_feedback_list_after_init * refactor: merge sync_dag_parent_and_hist and hist.append into one call * fix uncommited rec bug * lint --------- Co-authored-by: xuangu-fang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…me()
Description
Motivation and Context
How Has This Been Tested?
Screenshots of Test Results (if appropriate):
Types of changes
📚 Documentation preview 📚: https://RDAgent--1028.org.readthedocs.build/en/1028/