-
Notifications
You must be signed in to change notification settings - Fork 4k
[python-package] Add type hints to the callback file #4093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
StrikerRUS
merged 17 commits into
microsoft:master
from
deddyjobson:add-type-hints-to-callback-file
Apr 10, 2021
Merged
Changes from 6 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
dc27837
added type hints; implemented one workaround
deddyjobson 557901a
resolving some linting errors
deddyjobson 0c0104b
Added doc strings
deddyjobson 482622c
fixed more linting errors
deddyjobson a4f639e
Made documentation more imperative.
deddyjobson 9853c1d
removed one type hint
deddyjobson e0cdeb0
more specific type hinting
deddyjobson 3349c55
added import
deddyjobson d30b9be
Apply suggestions from code review
deddyjobson c47a8b7
made a class and function private
deddyjobson bca340b
Apply suggestions from code review
deddyjobson 640c55e
linting error fix
deddyjobson fee9831
more linting errors
deddyjobson 1200fa9
removing the decorator
deddyjobson 03652ea
ignore mypy function attribute errors
deddyjobson 3e4ff5b
fix lints
deddyjobson 3309bf8
Merge branch 'master' into add-type-hints-to-callback-file
jameslamb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.